Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

WIP: Adding accessibility features #2359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CristianAUnisa
Copy link

@CristianAUnisa CristianAUnisa commented Jun 26, 2021

Made the theme button toggable by keyboard
Added aria-label to many without any text (usually, they contains Font Awesome icons)
Added aria-hidden whenever necessary
Labelled the "Copy URL and Description" contained in footer
Added an hidden label for the menu toggle for mobile accessibility
Changed some colors to meet the Color Contrast AA level: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

Description

Resolves: #none

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

Made the theme button toggable by keyboard
Added aria-label to many <a> without any text (usually, they contains Font Awesome icons)
Added aria-hidden whenever necessary
Labelled the "Copy URL and Description" contained in footer
Added an hidden label for the menu toggle for mobile accessibility
Changed some colors to meet the Color Contrast AA level: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
@CristianAUnisa CristianAUnisa requested a review from a team as a code owner June 26, 2021 18:29
@CristianAUnisa
Copy link
Author

CristianAUnisa commented Jun 27, 2021

There's a line of code you can find there at line 13 that's not showing when you toggle the menu. Should it be deleted?

<div class="menu w-100">
    <div id="nav-left" class="position-relative flex-col">
    <a class="nav-anchor" href="/"> <!-- This one right here -->
        <span id="nav-home" class="fas fa-home fa-fw"></span>
    </a>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant