add multi-threading toggle, fix binary caching string

[eriktaubeneck]

adds a toggle for multi-threading

Summary by CodeRabbit

• New Features

  • Introduced a multi-threading option in the IPAForm component, allowing users to enable or disable multi-threading for their queries.

• Enhancements

  • Updated target path construction to use compiled_id instead of commit_hash, improving consistency and clarity.

• Bug Fixes

  • Adjusted internal logic to ensure the new multi-threading option is correctly passed and utilized within the system.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
draft	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 0:56am

[coderabbitai]

Walkthrough

The recent changes enhance the IPAForm component with multi-threading control and adjust the Paths class to use compiled_id instead of commit_hash. Additionally, updates to the IPAQuery class and related components incorporate multi-threading support, ensuring seamless integration across the system.

Changes

File	Change Summary
server/app/query/create/page.tsx	Added multiThreadingEnabled state and UI elements to control multi-threading in IPAForm component.
sidecar/app/local_paths.py	Changed commit_hash to compiled_id in Paths class and adjusted target_path construction accordingly.
sidecar/app/query/ipa.py	Added commit_hash and multi_threading to various classes, updating related logic.
sidecar/app/routes/start.py	Added multi_threading parameter to start_ipa_helper function and updated compiled_id construction.

In code we trust, with threads we weave,
Enhancing paths, new goals achieve.
The rabbit hops through lines so neat,
With multi-threading, tasks complete.
Commit IDs now compiled,
In the garden of code, we’ve smiled.
🌟🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c60830 and 2934d4a.

Files selected for processing (4)

• server/app/query/create/page.tsx (3 hunks)
• sidecar/app/local_paths.py (2 hunks)
• sidecar/app/query/ipa.py (6 hunks)
• sidecar/app/routes/start.py (2 hunks)

Additional comments not posted (17)

sidecar/app/local_paths.py (2)

10-10: The addition of the compiled_id attribute looks good.

---

25-25: The update to use compiled_id in the target_path property is correct.

sidecar/app/routes/start.py (4)

44-44: The addition of the multi_threading parameter to the start_ipa_helper function is correct.

---

52-56: The update to include _multi-threading in the compiled_id based on the multi_threading parameter is correct.

---

61-61: The update to pass compiled_id to the Paths constructor is correct.

---

69-69: The update to pass multi_threading to the IPAHelperQuery constructor is correct.

sidecar/app/query/ipa.py (9)

29-29: The addition of the commit_hash attribute to the IPAQuery class looks good.

---

123-123: The update to use query.commit_hash in the IPACheckoutCommitStep class is correct.

---

146-146: The update to use query.paths.target_path in the IPACorrdinatorCompileStep class is correct.

---

166-166: The addition of the multi_threading attribute to the IPAHelperCompileStep class looks good.

---

175-175: The update to use query.multi_threading in the IPAHelperCompileStep class is correct.

---

181-181: The update to pass multi_threading to the IPAHelperCompileStep constructor is correct.

---

190-190: The update to include multi-threading in the build command based on the multi_threading attribute is correct.

---

404-404: The addition of the multi_threading attribute to the IPAHelperQuery class looks good.

---

Line range hint 111-111: The update to use query.commit_hash in the IPACoordinatorQuery class is correct.

server/app/query/create/page.tsx (2)

130-130: The addition of the multiThreadingEnabled state to the IPAForm component looks good.

---

359-379: The addition of the UI element to control the multiThreadingEnabled state in the IPAForm component is correct.