migrate all timestamp columns to timestamptz (timezone aware) #54

eriktaubeneck · 2024-06-21T21:28:26Z

this alters the db so that all columns use the timezone aware version of timestamp.

Summary by CodeRabbit

Documentation
- Added a comment explaining the use of toISOString() for UTC timestamps.
Chores
- Updated database schema to use timestamptz for timestamp fields and adjusted them to UTC time zone.

…hing in utc

vercel · 2024-06-21T21:28:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
draft	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2024 9:28pm

coderabbitai · 2024-06-21T21:28:33Z

Walkthrough

The recent changes focus on improving how timestamps are handled in both JavaScript code and the database schema. A comment has been added to the validateApiKey function to explain the UTC behavior of toISOString(), and multiple database tables have been updated to store timestamps in UTC using the timestamptz data type. These updates aim to standardize timestamp handling across the server and the database.

Changes

Files	Change Summary
`server/data/helper_party_api_key.ts`	Comment added explaining `toISOString()` for UTC timestamps before `currentTimestamp` initialization.
`server/supabase/migrations/20240621172426_timestamptz.sql`	Updated multiple tables to change timestamp fields to `timestamptz` and adjust them to UTC time.

Poem

In the code where time resides,
UTC now our trusted guides,
Timestamps dance in perfect sync,
No more errors on the brink.
Database fields with timestamptz bright,
In the dawn of data’s light. ☀️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fb521c3 and f1cf83d.

Files selected for processing (2)

server/data/helper_party_api_key.ts (1 hunks)
server/supabase/migrations/20240621172426_timestamptz.sql (1 hunks)

Files skipped from review due to trivial changes (2)

server/data/helper_party_api_key.ts
server/supabase/migrations/20240621172426_timestamptz.sql

akoshelev · 2024-06-24T18:05:11Z

server/data/helper_party_api_key.ts

@@ -8,6 +8,8 @@ export async function validateApiKey(
  key: string,
 ): Promise<boolean> {
  const supabase = await createSupabaseServiceClient();
+  // toISOString() always and only returns UTC timestamps
+  // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString
  const currentTimestamp = new Date().toISOString();


you may want to refactor this later to be able to unit test the expiration

could also add an already expired key to seed.sql for that test. it's a good test to add

akoshelev · 2024-06-24T18:05:52Z

server/supabase/migrations/20240621172426_timestamptz.sql

@@ -0,0 +1,17 @@
+alter table queries alter created_at type timestamptz using created_at at time zone 'utc';


just to make sure - do we generate the timestamp on DB side for all of these columns during insert/update?

eriktaubeneck added 2 commits June 21, 2024 14:15

migrate all timestamp columns to timestamptz (timezone aware). everyt…

896707a

…hing in utc

add comment for clarity on toISOString behavior

f1cf83d

eriktaubeneck requested a review from akoshelev June 21, 2024 21:28

vercel bot deployed to Preview June 21, 2024 21:28 View deployment

coderabbitai bot reviewed Jun 21, 2024

View reviewed changes

akoshelev reviewed Jun 24, 2024

View reviewed changes

akoshelev approved these changes Jun 24, 2024

View reviewed changes

eriktaubeneck mentioned this pull request Jun 24, 2024

test expired keys #58

Open

eriktaubeneck merged commit 832dd5f into main Jun 25, 2024
3 checks passed

eriktaubeneck deleted the timestamptz branch June 26, 2024 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate all timestamp columns to timestamptz (timezone aware) #54

migrate all timestamp columns to timestamptz (timezone aware) #54

eriktaubeneck commented Jun 21, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 21, 2024 •

edited

Loading

coderabbitai bot commented Jun 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

akoshelev Jun 24, 2024

eriktaubeneck Jun 24, 2024

akoshelev Jun 24, 2024

eriktaubeneck Jun 24, 2024

		@@ -0,0 +1,17 @@
		alter table queries alter created_at type timestamptz using created_at at time zone 'utc';

migrate all timestamp columns to timestamptz (timezone aware) #54

migrate all timestamp columns to timestamptz (timezone aware) #54

Conversation

eriktaubeneck commented Jun 21, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Jun 21, 2024 • edited Loading

coderabbitai bot commented Jun 21, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

akoshelev Jun 24, 2024

Choose a reason for hiding this comment

eriktaubeneck Jun 24, 2024

Choose a reason for hiding this comment

akoshelev Jun 24, 2024

Choose a reason for hiding this comment

eriktaubeneck Jun 24, 2024

Choose a reason for hiding this comment

eriktaubeneck commented Jun 21, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 21, 2024 •

edited

Loading

coderabbitai bot commented Jun 21, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)