Validating the encrypted reports generated on ios can be decrypted in rust #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
+ Coverage 90.87% 90.95% +0.08%
==========================================
Files 183 183
Lines 25691 25882 +191
==========================================
+ Hits 23346 23541 +195
+ Misses 2345 2341 -4 ☔ View full report in Codecov by Sentry. |
andyleiserson
approved these changes
May 20, 2024
ipa-core/src/report.rs
Outdated
|
|
||
| #[test] | ||
| fn check_compatibility_conversion_with_ios_encryption() { | ||
| let enc_report_bytes1 = hex::decode("741cd5012df1cf8f337258066a55c408d1052297af27a35bdef571773215ad7cbd367eab689145a24ad9666a12731a221ff5548cc7591a5ce50da4dcde203cc614175759ef230641adac977187143471b512f1c8fd95eafeb53602d90a69a6411f3af9cb44e02417f6f27b7162f08bff009e82b1c2c2aaaf156f010000007777772e6162632e636f6d").unwrap(); |
There was a problem hiding this comment.
If you end a line in a string literal with a backslash, rustc removes the backslash and any leading whitespace on the following line. This can be used to embed blobs like this while keeping the line length manageable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this process is manual needing copy pasta of the bytes generated as proper integration testing will take more work