Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the saturated addition panic inside IPA #1286

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Fix the saturated addition panic inside IPA #1286

merged 5 commits into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. Add a test that reproduces saturation panic 

    It required quite a bit of plumbing to make the compact gate stuff work
    @akoshelev
    akoshelev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1374efd View commit details
    Browse the repository at this point in the history

  2. Fix the panic inside addition by using wider compact gate step

    @akoshelev
    akoshelev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2facdcb View commit details
    Browse the repository at this point in the history

  3. Move TestExecutionStep to protocol folder 

        Otherwise, I can't make it work with compact gate `track_steps`.
    It could be possible if we include stuff from `test_fixture` folder
    conditionally, but `track_steps` does not support that currently.
    @akoshelev
    akoshelev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3da73c9 View commit details
    Browse the repository at this point in the history

  4. Add in-memory compact gate tests to the CI

    @akoshelev
    akoshelev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    952e277 View commit details
    Browse the repository at this point in the history

  5. Remove commented code

    @akoshelev
    akoshelev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6d7c1d2 View commit details
    Browse the repository at this point in the history