Making this test less flaky, and good error reports #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let max_tolerance = (*expected as f64) * tolerance + 10.0; | ||
| assert!( | ||
| (expected - actual).abs() as f64 <= max_tolerance, | ||
| "expected {:?} unmatched events, got {:?}", |
There was a problem hiding this comment.
it might be worth reframing this around "expected {:?} +/- {tolerance}"
| ); | ||
| for (expected, actual) in zip(EXPECTED_HISTOGRAM.iter(), histogram) { | ||
| assert!( | ||
| (expected - actual).abs() <= expected / 20 + 10, |
There was a problem hiding this comment.
something explaining this math would be helpful
eriktaubeneck
approved these changes
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 93.41% 93.47% +0.05%
==========================================
Files 208 209 +1
Lines 33798 33823 +25
==========================================
+ Hits 31574 31615 +41
+ Misses 2224 2208 -16 ☔ View full report in Codecov by Sentry. |
benjaminsavage
merged commit fbce8ec
into
private-attribution:main
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.