Suppress metrics table in passing test runs #1400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::io::stdout()
is not captured in test runs -- see rust-lang/rust#90785.The
Display
implementation forcomfy_table::Table
assembles everything into a string anyways (actually worse -- it assembles into aVec<String>
and then callsjoin
). So, even if we were to have other places where we want thestd::io::Write
interface, there is unlikely to be a performance benefit of the previous implementation.