Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress metrics table in passing test runs #1400

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

andyleiserson
Copy link
Collaborator

std::io::stdout() is not captured in test runs -- see rust-lang/rust#90785.

The Display implementation for comfy_table::Table assembles everything into a string anyways (actually worse -- it assembles into a Vec<String> and then calls join). So, even if we were to have other places where we want the std::io::Write interface, there is unlikely to be a performance benefit of the previous implementation.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.54%. Comparing base (95dbe6a) to head (04ce112).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/telemetry/stats.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
- Coverage   93.68%   93.54%   -0.15%     
==========================================
  Files         223      223              
  Lines       37765    38261     +496     
==========================================
+ Hits        35382    35792     +410     
- Misses       2383     2469      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akoshelev akoshelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that was my bad, thanks for fixing it!

@andyleiserson andyleiserson merged commit 91aa71d into private-attribution:main Nov 4, 2024
12 checks passed
@andyleiserson andyleiserson deleted the quiet branch November 4, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants