Add query size parameter to IPA queries #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Jun 22, 2023
src/helpers/transport/query.rs
Outdated
| ) -> Result<Self, QueryConfigError> | ||
| where | ||
| <S as TryInto<usize>>::Error: Debug, | ||
| S: TryInto<usize> + TryInto<u32>, |
There was a problem hiding this comment.
Don't you only need one of these? (The latter?)
src/helpers/transport/query.rs
Outdated
| .and_then(NonZeroU32::try_from) | ||
| .map_err(|_| QueryConfigError::BadQuerySize { | ||
| actual_size: sz, | ||
| max_size: MAX_QUERY_SIZE, |
There was a problem hiding this comment.
Are you relying on MAX_QUERY_SIZE being equal to NonZeroU32::MAX?
... and I just saw that it is not. We'll need a new type for this, with a TryFrom implementation that doesn't accept 231, as this does.
src/net/http_serde.rs
Outdated
| @@ -109,10 +109,13 @@ pub mod query { | |||
| async fn from_request(req: &mut RequestParts<B>) -> Result<Self, Self::Rejection> { | |||
| #[derive(serde::Deserialize)] | |||
| struct QueryTypeParam { | |||
| // TODO: serde custom error? | |||
| size: NonZeroU32, | |||
There was a problem hiding this comment.
We might need a new type for this is MAX_QUERY_SIZE changes.
There was a problem hiding this comment.
added a new type QuerySize - made it cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPA needs to know how many records will be submitted inside a query. It is important for multiple reasons, one of them is to be able to tune the size of send/receive buffer