Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #824

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Logging improvements #824

merged 2 commits into from
Nov 1, 2023

Commits on Oct 31, 2023

  1. Configure logging from env as well 

    Currently, it is not possible to have module-level granularity configuration for logging. Setting up `-vvv` makes IPA to log all trace events, including those coming from third-party.

This change enables this functionality by optionally reading logging configuration from `RUST_LOG`
    @akoshelev
    akoshelev committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cea3339 View commit details
    Browse the repository at this point in the history

  2. Add send and receive trace spans 

    ```
2023-10-31T20:35:01.600364Z TRACE oprf_ipa_query{sz=10000}:send{i=914 total=1658 to=H2 gate="protocol/binary_validator/row1/attributed_breakdown_key/bit7"}: ipa::helpers::gateway::send: new
2023-10-31T20:35:01.600382Z TRACE oprf_ipa_query{sz=10000}:send{i=914 total=1658 to=H2 gate="protocol/binary_validator/row1/attributed_breakdown_key/bit7"}: ipa::helpers::gateway::send: close time.busy=2.42µs time.idle=15.7µs
```

it is a bit verbose, but logging enter/exit allows to see if send was completed (because it may be blocked if it is out of bounds) and the timing.
    @akoshelev
    akoshelev committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    517e6e4 View commit details
    Browse the repository at this point in the history