make random event generator generate "min_events_per_user..=max_events_per_user" number of events #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add OPRF root step to compact was getting an error running OPRF IPA with compact steps enabled ``` cannot narrow from the invalid step oprf_ipa stack trace: ``` * Fix a compile bug inside compact map * Reorder constants and fix the step number for OPRF
|
Can you support both use cases by adding |
…umber of events a user can generate
taikiy
changed the title
taikiy
changed the title
Comment on lines
+119
to
+122
| NonZeroU64::new(1).unwrap(), | ||
| NonZeroU32::new(64).unwrap(), | ||
| NonZeroU32::new(64).unwrap(), | ||
| 64, |
There was a problem hiding this comment.
One cannot tell by looking at this how these numbers are used, and what they mean.
There was a problem hiding this comment.
Could you tell me which part is unclear? I think the tuple variable names are self-explanatory and the comment describes why we need 1 and 64. Maybe change the integer literals to constants?
benjaminsavage
approved these changes
Nov 7, 2023
| max_events_per_user: NonZeroU32::try_from(max_events_per_user).unwrap(), | ||
| report_filter: ReportFilter::All, | ||
| conversion_probability: None, | ||
| } | ||
| } | ||
|
|
||
| fn max_user_id(&self) -> usize { | ||
| usize::try_from(self.max_user_id.get()).unwrap() | ||
| fn user_count(&self) -> usize { |
There was a problem hiding this comment.
I still find "user_count" confusing. Can you add a comment here to describe what it means?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPRF steps depend on the maximum number of rows of all given users. In order to generate steps for the
Compactgate, we need to be able to specify exactly how many user(s) and events we want to generate from theEventGenerator.The current
EventGeneratorrandomly generates events between[1..=max_events_per_user]per user, for up tomax_user_idusers (the name is confusing. I renamed it touser_count). It allows us to control the total number of events to generate, but not the number of events per user.This is a quick change to fixate the number of events users can produce. We lose the randomness, but for the testing purpose I don't think that is a big deal as the randomness doesn't follow a real-world distribution anyway. Ideally, callers of the generator should be able to pass in a distribution of events-per-user.
This fixes other issues mentioned in #830. There's another issue with the generated timestamps exceeding the current 20 bits limit. I'll make another PR for that.