-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade esbuild #211
Conversation
I know, but I don't think that will prevent this PR. |
Why's that? |
That will require additional configurations, which most people won't notice that. Also, that will introduce two or more "esbuild" installations in |
If those are the only motivations you have to make this PR, I think it's preventable. Majority of users don't care about using the latest esbuild; they're just happy with the speed benefits. Amongst those that do care, the majority are happy with the JSYK I understand the benefits of having it as a peer dependency, and it will be in the future. In case you missed it in the readme:
Currently, the maintenance cost I would take by expecting users to understand npm's major-zero semver and how it's different from normal semver is too high. Having this road-block actually saves me time at a small cost to the API. |
Hi, |
That's a good motivation. Thanks for sharing it! Will try to release tomorrow. Sorry, its late here. (Don't hesitate to request an upgrade in the future, especially if theres a problem. I'm not against it, just busy.) |
I wish "esbuild" can be a peer dependency, which will allow users to upgrade by themselves.