-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(paths): handle ../
in relative path check
#18
fix(paths): handle ../
in relative path check
#18
Conversation
@privatenumber Thanks for quick refactor, can we merge and release? |
Thanks for the PR and the test-case. I appreciate you reporting issues, but in the future, please:
|
Sorry about your feeling. At first, I just didn't find what is causing the issue. Personally I also maintain a lot of OSS projects, so I understand reproduction is required, and I did provide, but the project is just huge to extract a minimal reproduction, I don't have idea what's the root cause, then I can't reduce the reproduction. That's just an idea when the error occurred, and then I tried to read the compiled codes, and had an idea how it was caused, but I believe I can't be so lucky for times. I apologize if you don't feel good on this, maybe I need to wait for seconds before posting the issue. Finally, hope you happiness. |
Thanks @JounQin I understand it can be tough to investigate and produce a reproduction. But it's either you do it or I do it, and it's often possible that the problem isn't even related to the project. I encourage you to spend that time before opening an issue next time. In the end, a clearly written issue with a reproduction saves everyone time. 👍 |
../
for relative paths../
in relative path check
🎉 This PR is included in version 4.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Yeah, I was too anxious before posting the issue. I need to improve this for my whole life.
🍺 |
close #17