-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve relative path extends in parent directory #77
fix: resolve relative path extends in parent directory #77
Conversation
Appreciate your contributions as always @nwalters512 ! I invited you to my private development org if you're interested. Would love to collaborate more! |
🎉 This PR is included in version 4.7.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @privatenumber! I accepted the invitation. |
Seems like this change broke something with resolution of My project is using
|
Would you mind filing a bug report, or a PR with a fix & test? |
Sorry, I can’t find time for that any soon. Just wanted to draw your attention. |
Thanks, but until the bug is proven to be in get-tsconfig, I'm not able to invest time debugging (often times it turns out it's unrelated and I'm end up just debugging stuff for other people). I'm going to lock this thread because it's not the appropriate place to discuss this. |
Closes #76.
Using
path.resolve
to obtain an absolute path ensures that we search all the way up, instead of stopping atdirectoryPath
.