test: refactor to await using

privatenumber · May 17, 2024 · a038611 · a038611
1 parent f327f64
commit a038611
Show file tree

Hide file tree

Showing 17 changed files with 125 additions and 189 deletions.
diff --git a/tests/specs/builds/bin.ts b/tests/specs/builds/bin.ts
@@ -5,9 +5,8 @@ import { pkgroll } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('bin', ({ test }) => {
-		test('supports single path', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('supports single path', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				bin: './dist/index.mjs',
@@ -36,9 +35,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			});
 		});
 
-		test('supports object', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('supports object', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				bin: {

diff --git a/tests/specs/builds/clean-dist.ts b/tests/specs/builds/clean-dist.ts
@@ -6,9 +6,8 @@ import { pkgroll, installTypeScript } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('clean dist', ({ test }) => {
-		test('no flag', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('no flag', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			installTypeScript(fixture.path);
 
@@ -54,9 +53,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(await fixture.exists('dist/nested2/index.d.ts')).toBe(true);
 		});
 
-		test('with flag', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('with flag', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			installTypeScript(fixture.path);
 

diff --git a/tests/specs/builds/dependencies.ts b/tests/specs/builds/dependencies.ts
@@ -4,9 +4,8 @@ import { pkgroll, installTypeScript } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('dependencies', ({ test }) => {
-		test('externalize dependencies', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('externalize dependencies', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/dependency-external.js',
@@ -27,8 +26,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('require(\'@org/name/path\')');
 		});
 
-		test('externalize types', async ({ onTestFinish }) => {
-			const fixture = await createFixture({
+		test('externalize types', async () => {
+			await using fixture = await createFixture({
 				'package.json': JSON.stringify({
 					types: 'dist/index.d.ts',
 					dependencies: {
@@ -47,7 +46,6 @@ export default testSuite(({ describe }, nodePath: string) => {
 				export const b: typeB;
 				`,
 			});
-			onTestFinish(async () => await fixture.rm());
 
 			installTypeScript(fixture.path);
 
@@ -63,8 +61,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('from \'@square-icons/react\'');
 		});
 
-		test('bundle in types if only in devDependency', async ({ onTestFinish }) => {
-			const fixture = await createFixture({
+		test('bundle in types if only in devDependency', async () => {
+			await using fixture = await createFixture({
 				'package.json': JSON.stringify({
 					types: 'dist/index.d.ts',
 					devDependencies: {
@@ -76,7 +74,6 @@ export default testSuite(({ describe }, nodePath: string) => {
 				},
 				'src/index.d.ts': 'export { A } from "react"',
 			});
-			onTestFinish(async () => await fixture.rm());
 
 			installTypeScript(fixture.path);
 
@@ -91,8 +88,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toBe('declare const A: { b: number };\n\nexport { A };\n');
 		});
 
-		test('externalize dependency & type despite devDependency type', async ({ onTestFinish }) => {
-			const fixture = await createFixture({
+		test('externalize dependency & type despite devDependency type', async () => {
+			await using fixture = await createFixture({
 				'package.json': JSON.stringify({
 					main: 'dist/index.js',
 					types: 'dist/index.d.ts',
@@ -113,7 +110,6 @@ export default testSuite(({ describe }, nodePath: string) => {
 				},
 				'src/index.ts': 'export { A } from "react"',
 			});
-			onTestFinish(async () => await fixture.rm());
 
 			installTypeScript(fixture.path);
 
@@ -134,9 +130,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(contentTypes).toBe('export { A } from \'react\';\n');
 		});
 
-		test('dual package - require', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('dual package - require', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/dependency-exports-require.js',
@@ -154,9 +149,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('cjs');
 		});
 
-		test('dual package - import', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('dual package - import', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/dependency-exports-import.js',
@@ -174,9 +168,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('esm');
 		});
 
-		test('imports map - default', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('imports map - default', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/dependency-imports-map.js',
@@ -194,9 +187,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('default');
 		});
 
-		test('imports map - node', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('imports map - node', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/dependency-imports-map.js',

diff --git a/tests/specs/builds/env.ts b/tests/specs/builds/env.ts
@@ -4,9 +4,8 @@ import { pkgroll } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('env', ({ test }) => {
-		test('dead code elimination via env', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('dead code elimination via env', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/conditional-require.js',

diff --git a/tests/specs/builds/minification.ts b/tests/specs/builds/minification.ts
@@ -4,9 +4,8 @@ import { pkgroll } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('minification', ({ test }) => {
-		test('minification', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('minification', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/target.js',

diff --git a/tests/specs/builds/output-commonjs.ts b/tests/specs/builds/output-commonjs.ts
@@ -4,9 +4,8 @@ import { pkgroll } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('output: commonjs', ({ test }) => {
-		test('{ type: commonjs, field: main, srcExt: js, distExt: js }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: commonjs, field: main, srcExt: js, distExt: js }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/index.js',
@@ -24,9 +23,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('module.exports =');
 		});
 
-		test('{ type: commonjs, field: main, srcExt: mts, distExt: js }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: commonjs, field: main, srcExt: mts, distExt: js }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/mts.js',
@@ -44,9 +42,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('exports.sayHello =');
 		});
 
-		test('{ type: commonjs, field: main, srcExt: cts, distExt: js }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: commonjs, field: main, srcExt: cts, distExt: js }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/cts.js',
@@ -64,9 +61,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('exports.sayHello =');
 		});
 
-		test('{ type: commonjs, field: main, srcExt: cts, distExt: cjs }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: commonjs, field: main, srcExt: cts, distExt: cjs }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/cts.cjs',
@@ -84,9 +80,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('exports.sayHello =');
 		});
 
-		test('{ type: module, field: main, srcExt: js, distExt: cjs }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: module, field: main, srcExt: js, distExt: cjs }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				type: 'module',
@@ -105,9 +100,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('module.exports =');
 		});
 
-		test('{ type: commonjs, field: main, srcExt: mjs, distExt: cjs }', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('{ type: commonjs, field: main, srcExt: mjs, distExt: cjs }', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/mjs.cjs',
@@ -125,9 +119,8 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(content).toMatch('exports.sayHello =');
 		});
 
-		test('nested directory', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('nested directory', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				main: './dist/nested/index.js',

diff --git a/tests/specs/builds/output-dual.ts b/tests/specs/builds/output-dual.ts
@@ -6,9 +6,8 @@ import { pkgroll } from '../../utils.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
 	describe('output: commonjs & module', ({ test }) => {
-		test('dual', async ({ onTestFinish }) => {
-			const fixture = await createFixture('./tests/fixture-package');
-			onTestFinish(async () => await fixture.rm());
+		test('dual', async () => {
+			await using fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
 				exports: {