fix(cjs): support file url (#18)

privatenumber · May 16, 2024 · 4a8a2dc · 4a8a2dc
1 parent 942e9bc
commit 4a8a2dc
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 7 deletions.
diff --git a/src/cjs/api/module-resolve-filename.ts b/src/cjs/api/module-resolve-filename.ts
@@ -1,9 +1,11 @@
 import path from 'node:path';
 import Module from 'node:module';
+import { fileURLToPath } from 'node:url';
 import { createPathsMatcher } from 'get-tsconfig';
 import { resolveTsPath } from '../../utils/resolve-ts-path.js';
 import type { NodeError } from '../../types.js';
 import { isRelativePath } from '../../utils/path-utils.js';
+import { fileUrlPrefix } from '../../utils/file-url.js';
 import {
 	isTsFilePatten,
 	tsconfig,
@@ -69,6 +71,11 @@ export const resolveFilename: ResolveFilename = (
 		request = request.slice(0, queryIndex);
 	}
 
+	// Support file protocol
+	if (request.startsWith(fileUrlPrefix)) {
+		request = fileURLToPath(request);
+	}
+
 	if (
 		tsconfigPathsMatcher
 

diff --git a/src/esm/hook/resolve.ts b/src/esm/hook/resolve.ts
@@ -6,11 +6,11 @@ import type {
 import { resolveTsPath } from '../../utils/resolve-ts-path.js';
 import type { NodeError } from '../../types.js';
 import { requestAcceptsQuery } from '../../utils/path-utils.js';
+import { fileUrlPrefix } from '../../utils/file-url.js';
 import {
 	tsconfigPathsMatcher,
 	tsExtensionsPattern,
 	getFormatFromFileUrl,
-	fileProtocol,
 	allowJs,
 	namespaceQuery,
 	getNamespace,
@@ -41,7 +41,7 @@ const resolveExplicitPath = async (
 
 	if (
 		!resolved.format
-		&& resolved.url.startsWith(fileProtocol)
+		&& resolved.url.startsWith(fileUrlPrefix)
 	) {
 		resolved.format = await getFormatFromFileUrl(resolved.url);
 	}

diff --git a/src/esm/hook/utils.ts b/src/esm/hook/utils.ts
@@ -21,8 +21,6 @@ export const fileMatcher = tsconfig && createFilesMatcher(tsconfig);
 export const tsconfigPathsMatcher = tsconfig && createPathsMatcher(tsconfig);
 export const allowJs = tsconfig?.config.compilerOptions?.allowJs ?? false;
 
-export const fileProtocol = 'file://';
-
 export const tsExtensionsPattern = /\.([cm]?ts|[tj]sx)($|\?)/;
 
 export const isJsonPattern = /\.json(?:$|\?)/;

diff --git a/src/utils/file-url.ts b/src/utils/file-url.ts
@@ -0,0 +1 @@
+export const fileUrlPrefix = 'file://';
diff --git a/tests/specs/smoke.ts b/tests/specs/smoke.ts
@@ -6,6 +6,8 @@ import outdent from 'outdent';
 import type { NodeApis } from '../utils/tsx.js';
 import { hasCoverageSourcesContent } from '../utils/coverage-sources-content.js';
 
+const isWindows = process.platform === 'win32';
+
 const cjsContextCheck = 'typeof module !== \'undefined\'';
 const tsCheck = '1 as number';
 
@@ -513,10 +515,17 @@ export default testSuite(async ({ describe }, { tsx }: NodeApis) => {
 						import './js/index.js?query=123';
 						import './js/index';
 						import './js/';
+
+						// absolute path
+						${
+							isWindows
+								? ''
+								: `import ${JSON.stringify(path.join(fixturePath, 'js/index.js'))};`
+						}
+
+						// absolute file url
 						import ${JSON.stringify(
-							packageType === 'module'
-								? new URL('js/index.js', pathToFileURL(fixturePath)).toString()
-								: path.resolve(fixturePath, 'js/index.js'),
+							new URL('js/index.js', pathToFileURL(fixturePath)).toString(),
 						)};
 
 						// No double .default.default in Dynamic Import