Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with MikroORM introduced with tsx v4.9.1 #541

Closed
4 of 6 tasks
DASPRiD opened this issue May 4, 2024 · 2 comments
Closed
4 of 6 tasks

Regression with MikroORM introduced with tsx v4.9.1 #541

DASPRiD opened this issue May 4, 2024 · 2 comments
Labels
bug Something isn't working outdated pending triage

Comments

@DASPRiD
Copy link

DASPRiD commented May 4, 2024

Acknowledgements

  • I read the documentation and searched existing issues to avoid duplicates
  • I understand this is a place to report a confirmed bug (not seek debugging help)
  • I understand this is a collaborative open source project, and relies on community contributions
  • I have read and understood the Contribution guide

Minimal reproduction URL

https://stackblitz.com/edit/node-wp3mk9

Version

v4.9.1

Node.js version

v20.12.2

Package manager

pnpm

Operating system

Linux

Problem & expected behavior (under 200 words)

TSX v4.9.1 introduced a regression when trying to load .ts config files for MikroORM. This was working fine so far, including v.4.9.0. I only see a single commit for v4.9.1, so that one must have introduced the regression:

96bc596

Contributions

  • I'm interested in working on this issue
  • I'm willing to offer financial support
@DASPRiD DASPRiD added bug Something isn't working pending triage labels May 4, 2024
@privatenumber
Copy link
Owner

Thanks for the report!

I guess we didn't have a test to cover this use case. Would you mind opening a PR with a test (& fix if youre able to)?

@privatenumber
Copy link
Owner

Based on the reproduction, looks like this was addressed via #544

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working outdated pending triage
Projects
None yet
Development

No branches or pull requests

2 participants