fix(esm): resolve absolute paths #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this also be addressing #541? |
|
@fardjad Would you mind adding a test? |
fardjad
force-pushed
the
fix-absolute-path-resolution
branch
from
2a65b01
to
5cbc7e3
Compare
fardjad
force-pushed
the
fix-absolute-path-resolution
branch
from
5cbc7e3
to
5d7ca18
Compare
|
@privatenumber Of course! I updated my PR. I wasn't sure where the best place to add the test would be. I decided to put it under the |
fardjad
force-pushed
the
fix-absolute-path-resolution
branch
from
18e18ce
to
5a5ca97
Compare
|
That works, but I consolidated it into the smoke test—previously, our tests would take super long from spawning so many processes. Thanks for your contribution! |
privatenumber
changed the title
privatenumber
changed the title
|
🎉 This issue has been resolved in v4.9.2 If you appreciate this project, please consider supporting this project by sponsoring ❤️ 🙏 |
This was referenced May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue described here: #543