Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused eslintConfig #620

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

nwalters512
Copy link
Contributor

Putting the ESLint config in eslint.config.js makes it discoverable by editor integrations so that they can show lint errors/fixes inline.

AFAICT lintroll completely ignores the eslintConfig property in package.json, so it already wasn't necessary (and there wasn't a @pvtnbr/* package installed to begin with). The ignore of tests/fixtures, despite being ignored in the first place, also just isn't necessary.

@privatenumber privatenumber changed the title Move ESLint configuration to eslint.config.js chore: remove unused eslintConfig Jul 24, 2024
@privatenumber
Copy link
Owner

Good catch, this should've been removed. The config is just passed in as CLI flags to lintroll now.

@privatenumber privatenumber merged commit 178f338 into privatenumber:master Jul 24, 2024
3 checks passed
@privatenumber
Copy link
Owner

This issue is now resolved in v4.16.3.

If you're able to, your sponsorship would be very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants