Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade esbuild to 0.24 #664

Closed
wants to merge 1 commit into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Oct 9, 2024

This bumps esbuild to version 0.24.0.

I wanted this since I'm affected by evanw/esbuild#3887, which prints a lot of warnings when I build with 0.23.0. I also want to use the exact same version of esbuild when running locally, and building for deployment.

Thanks for an amazing tool! 🙏

@privatenumber
Copy link
Owner

Thank you for the PR, but I typically don't accept esbuild upgrade requests unless they address a specific bug or issue. In this case, esbuild was released with a breaking change label, which poses unnecessary risk to tsx users without clear benefit.

If your main motivation is to standardize on a single version of esbuild, I recommend using a package manager override to achieve that in your project.

Since tsx is designed to be user-friendly, the average user won't be concerned with dependency de-duplication, and we want to avoid causing potential disruptions unless absolutely necessary.

@LinusU
Copy link
Author

LinusU commented Oct 11, 2024

Makes sense 👍

I'll look into using overrides instead!

It would be neat if tsx used peer-dependencies to let users bring their own version of esbuild while at the same time indicating which versions are compatible. But as you explained, that probably doesn't vibe with the intention of this project either 😅

@LinusU LinusU closed this Oct 11, 2024
@LinusU LinusU deleted the esbuild-0-24 branch October 11, 2024 12:34
@theoludwig

This comment was marked as off-topic.

Repository owner locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants