Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Added test for set and remove Objects from localStorage. #231

Merged
merged 1 commit into from
Apr 23, 2015

Conversation

manrajgrover
Copy link
Contributor

Fixes indentions and typos. Added test for set and remove keys from Objects.

var returned = ls.getItem("key");
expect(ls.getItem("key")).toEqual(obj);
expect(returned["foo"]).toBe("bar");
ls.removeItem("foo");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are never setting foo in localStorage so you are not removing anything here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. What I meant is "set and remove Objects". I was trying something else back then. Fixed it. Please review the code.

@manrajgrover manrajgrover changed the title Added test for set and remove keys from Objects. Added test for set and remove Objects from localStorage. Apr 5, 2015
@irdan
Copy link
Member

irdan commented Apr 5, 2015

Looks like the indentation still needs work. it should be intended two spaces from the depth of describe, right now it appears to be indented by a single space.

@manrajgrover
Copy link
Contributor Author

@irdan sir,

Hi! :)
Major part of the file had one space in front of it. That's why I followed the same. If two space indention is required please let me know, will commit the change.

@smcgregor
Copy link
Member

There are a few inconsistencies in the file's whitespace. Your change makes it more consistent within the file, but it is still contrary to our style guide and good style in general. Blocks should be indented two spaces for every level they are nested in.

@manrajgrover
Copy link
Contributor Author

@smcgregor sir,

Hi! :)

I have fixed the indentation for the whole file. Please review the code.

@smcgregor
Copy link
Member

Running on TravisCI

@smcgregor
Copy link
Member

Passes. Can you squash the commits and I will merge?

@manrajgrover
Copy link
Contributor Author

Hi @smcgregor sir,

Sir I have squashed last two commits. Please let me know any other changes.

@smcgregor
Copy link
Member

I think you can squash all your commits on this pull request into a single commit.

@manrajgrover
Copy link
Contributor Author

Hi @smcgregor sir,

I have squashed all commits. :)

smcgregor added a commit that referenced this pull request Apr 23, 2015
Added test for set and remove Objects from localStorage.
@smcgregor smcgregor merged commit 0ad16e4 into privly:master Apr 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants