-
Notifications
You must be signed in to change notification settings - Fork 48
Added test for set and remove Objects from localStorage. #231
Conversation
var returned = ls.getItem("key"); | ||
expect(ls.getItem("key")).toEqual(obj); | ||
expect(returned["foo"]).toBe("bar"); | ||
ls.removeItem("foo"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are never setting foo
in localStorage so you are not removing anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. What I meant is "set and remove Objects". I was trying something else back then. Fixed it. Please review the code.
Looks like the indentation still needs work. |
@irdan sir, Hi! :) |
There are a few inconsistencies in the file's whitespace. Your change makes it more consistent within the file, but it is still contrary to our style guide and good style in general. Blocks should be indented two spaces for every level they are nested in. |
@smcgregor sir, Hi! :) I have fixed the indentation for the whole file. Please review the code. |
Passes. Can you squash the commits and I will merge? |
a46e097
to
ff9a792
Compare
Hi @smcgregor sir, Sir I have squashed last two commits. Please let me know any other changes. |
I think you can squash all your commits on this pull request into a single commit. |
ff9a792
to
29343d7
Compare
Hi @smcgregor sir, I have squashed all commits. :) |
Added test for set and remove Objects from localStorage.
Fixes indentions and typos. Added test for set and remove keys from Objects.