Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: project addition by mohitparmar1 #1332 #1333

Closed
wants to merge 2 commits into from
Closed

chore: project addition by mohitparmar1 #1332 #1333

wants to merge 2 commits into from

Conversation

mohitparmar1
Copy link
Contributor

close issue #1332

@mohitparmar1
chore: project addition by mohitparmar1 priyankarpal#1332
1f6a181 
Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jun 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ❌ Failed (Inspect) Jun 25, 2023 5:36am

github-actions[bot]
github-actions bot reviewed Jun 23, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mohitparmar1! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jun 23, 2023
priyankarpal
priyankarpal requested changes Jun 24, 2023
View reviewed changes
src/DB/projects.json Outdated
Comment on lines 2696 to 2701
{
"link": "https://github.com/mohitparmar1/Followers-Animation",
"title": "Followers Animation",
"description": "its a followers increasing animation ",
"tech": ["Html","Css","javascript"]
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have already added projects before. So add the code to the previous one. Check contributing. md for more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done changes

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC changes-required changes-required and removed wait for reviewers wait for the maintainer labels Jun 24, 2023
@priyankarpal priyankarpal linked an issue Jun 24, 2023 that may be closed by this pull request
Data: project addition by mohitparmar1 #1332
Closed
3 tasks
@priyankarpal
Copy link
Owner

also. there are some conflicts errors please resolve

@priyankarpal priyankarpal added the conflict this branch has conflicts error label Jun 24, 2023
@mohitparmar1
Merge branch 'main' into patch-1
2410dbf 
Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jun 25, 2023
priyankarpal
priyankarpal requested changes Jun 25, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that your repository doesn't contain any code; it only consists of a README file. As per the guidelines outlined in GSSoS'23, this is considered invalid. Therefore, if you persist in posting such spam, this pull request will be closed, and there's a possibility that you may be blocked.

image

@priyankarpal
Copy link
Owner

also, there are no contribution guidelines, license, code of conduct

image

@priyankarpal priyankarpal added invalid Inappropriate or invalid and removed gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC conflict this branch has conflicts error labels Jun 25, 2023
priyankarpal
priyankarpal requested changes Jun 25, 2023
View reviewed changes
src/DB/projects.json
@@ -2623,7 +2623,16 @@
"title": "Leads Tracker",
"description": "its a tracker that track our important tabs",
"tech": ["html", "css", "javascript"]
},
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a ,

Suggested change
}
},

src/DB/projects.json
@@ -2623,7 +2623,16 @@
"title": "Leads Tracker",
"description": "its a tracker that track our important tabs",
"tech": ["html", "css", "javascript"]
},
}
"Projects": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Suggested change
"Projects": [

src/DB/projects.json Show resolved Hide resolved
@mohitparmar1
Copy link
Contributor Author

closing this pr and making new changes

@mohitparmar1 mohitparmar1 deleted the patch-1 branch June 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal requested changes

Assignees

@mohitparmar1 mohitparmar1

Labels
changes-required changes-required invalid Inappropriate or invalid projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data: project addition by mohitparmar1
2 participants
@mohitparmar1 @priyankarpal