Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: project addition by vivekrawat21 #1423 #1424

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

vivekrawat21
Copy link
Contributor

@vivekrawat21 vivekrawat21 commented Jun 27, 2023

Related Issue

Issue : #1423

Checklist for projects addition

  • My project has contribution guidelines.
  • My project has a Code of Conduct.
  • My project has a README file.
  • My project has a License.

Please note that if your project doesn't meet these requirements, your PR may be closed. Make sure to include these elements in your project before submitting the PR.

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 29, 2023 8:59am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @vivekrawat21! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal priyankarpal added conflict this branch has conflicts error changes-required changes-required labels Jun 27, 2023
@priyankarpal
Copy link
Owner

this branch has a conflicts error. Please resolve it

Signed-off-by: Vivek Rawat <116631005+vivekrawat21@users.noreply.github.com>
@vivekrawat21
Copy link
Contributor Author

this branch has a conflicts error. Please resolve it

resolved 👍🏼

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to merge the pull request, it is essential that your projects include a valid contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

@priyankarpal
Copy link
Owner

also, add issue number to the PR description @vivekrawat21

Signed-off-by: Vivek Rawat <116631005+vivekrawat21@users.noreply.github.com>
@vivekrawat21
Copy link
Contributor Author

Thankyou for suggestions
and sorry for inconvinience actually i am newbie contributor so i am unfamilier with many terms .
i resolved the issues as per my knowledge .
Please check the pr now @priyankarpal

@priyankarpal priyankarpal linked an issue Jun 29, 2023 that may be closed by this pull request
7 tasks
@priyankarpal priyankarpal merged commit 2fa01db into priyankarpal:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-required changes-required conflict this branch has conflicts error projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: project addition by
2 participants