Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some hints from LGTM #159

Merged
merged 3 commits into from
Nov 13, 2021
Merged

Fix some hints from LGTM #159

merged 3 commits into from
Nov 13, 2021

Conversation

carterbox
Copy link
Collaborator

@carterbox carterbox commented Nov 12, 2021

Removes dead code using hints from LGTM.

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 1 alert and fixes 3 when merging 222eba6 into 61b03d2 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request fixes 3 alerts when merging 4d2db63 into 61b03d2 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@prjemian prjemian added this to the v1.0.0-release milestone Nov 12, 2021
@prjemian prjemian added the task label Nov 12, 2021
@carterbox carterbox marked this pull request as ready for review November 13, 2021 18:18
@carterbox carterbox requested a review from prjemian November 13, 2021 18:18
Copy link
Owner

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carterbox carterbox merged commit a5f3900 into main Nov 13, 2021
@carterbox carterbox deleted the lgtm-hints branch November 13, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants