Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty #O or #P list should not return empty string #196

Closed
prjemian opened this issue Aug 15, 2019 · 0 comments · Fixed by #197
Closed

empty #O or #P list should not return empty string #196

prjemian opened this issue Aug 15, 2019 · 0 comments · Fixed by #197
Assignees
@prjemian
Labels
bug
Milestone
2021.1.2

Comments

@prjemian
Copy link
Owner

When the #On or #Pn control lines are parsed, if there are no positioners specified (see BCDA-APS/apstools#222 and aps-8id-dys/ipython-8idiuser#13), the result should be an empty list ([]).

Presently, #O0 results in [['']] and #P0 results in [].
@prjemian prjemian added the bug label Aug 15, 2019
@prjemian prjemian added this to the 2021.1.2 milestone Aug 15, 2019
@prjemian prjemian self-assigned this Aug 15, 2019
@prjemian prjemian mentioned this issue Aug 15, 2019
Closed
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
TST #196 data files for the issue
8777ade
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
TST #196
aa8687a
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
MNT #196
750ab15
@prjemian prjemian mentioned this issue Aug 15, 2019
Merged
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
TST #196
a4158a2
@prjemian prjemian mentioned this issue Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
2021.1.2
Development

Successfully merging a pull request may close this issue.

handle empty empty #O0 or #P0 list prjemian/spec2nexus
1 participant
@prjemian