Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Diagram parameter from edge segmentation algorithms #378

Closed
prmr opened this issue Sep 8, 2020 · 0 comments
Closed

Remove Diagram parameter from edge segmentation algorithms #378

prmr opened this issue Sep 8, 2020 · 0 comments
Assignees
@prmr
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Milestone
Release 3.0.2

Comments

@prmr
Copy link
Owner

prmr commented Sep 8, 2020

The parameter of type Diagram dates back to when Edge nodes did not store a reference to their containing diagram. This parameter can now be removed to simplify the code.

This issue is a special case of #230.
@prmr prmr added refactoring A proposal to refector or generally improve the code main Issues with the main code base labels Sep 8, 2020
@prmr prmr added this to the Release 3.1 milestone Sep 8, 2020
@prmr prmr self-assigned this Sep 8, 2020
prmr added a commit that referenced this issue Sep 8, 2020
@prmr
#378 Remove Diagram parameter from hasSelfEdge
1131f5b
prmr added a commit that referenced this issue Sep 8, 2020
@prmr
#378 Remove Diagram parameter from computePointPosition
71545ad
prmr added a commit that referenced this issue Sep 8, 2020
@prmr
#378 Remove Diagram parameter from getAllEdgesForSide
a4f3144
prmr added a commit that referenced this issue Sep 8, 2020
@prmr
#378 Remove Diagram parameter from computePosition
4c117be
prmr added a commit that referenced this issue Sep 8, 2020
@prmr
#378 Remove Diagram parameter from getPath
124a062
@prmr prmr closed this as completed Sep 8, 2020
@prmr prmr modified the milestones: Release 3.1, Release 3.0.2 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prmr prmr

Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Projects
None yet
Milestone
Release 3.0.2
Development

No branches or pull requests
1 participant
@prmr