Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imperfect shape intersection for rounded rectangle and ellipse #401

Closed
prmr opened this issue Jan 13, 2021 · 0 comments
Closed

Imperfect shape intersection for rounded rectangle and ellipse #401

prmr opened this issue Jan 13, 2021 · 0 comments
Labels
feature A feature request main Issues with the main code base
Milestone

Comments

@prmr
Copy link
Owner

prmr commented Jan 13, 2021

Description
The current viewers do not compute a precise intersection between an edge and a shape that is not a rectangle or a circle. This includes rounded rectangles (states in state diagrams) and ellipses (use cases in use case diagrams).

image

The reason for this is that up to now a simpler algorithm is used that computes the intersection with the shape's bounding box. For high-quality rendering of diagrams, it would be nice to compute the intersection precisely.

Additional information
The solution should respect the existing design, which is illustrated in the code through method CircularStateNodeViewer#getConnectionPoint. The intersection algorithms should be implemented in GeomUtils and tested, and then used in the node viewers for state and use case nodes, respectively.

@prmr prmr added feature A feature request main Issues with the main code base labels Jan 13, 2021
@prmr prmr added this to the Release 3.2 milestone Jan 13, 2021
yingjie-xu added a commit to yingjie-xu/JetUML that referenced this issue Jan 18, 2021
yingjie-xu added a commit to yingjie-xu/JetUML that referenced this issue Jan 18, 2021
prmr pushed a commit that referenced this issue Jan 18, 2021
@prmr prmr closed this as completed Jan 27, 2021
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature request main Issues with the main code base
Projects
None yet
Development

No branches or pull requests

1 participant