Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the StringViewer #413

Closed
prmr opened this issue Feb 12, 2021 · 0 comments
Closed

Refactor the StringViewer #413

prmr opened this issue Feb 12, 2021 · 0 comments
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Milestone
Release 3.2

Comments

@prmr
Copy link
Owner

prmr commented Feb 12, 2021 •
edited
Loading

The StringViewer class used to draw strings on the canvas creates a very high number of Text objects at runtime, and returns overly conservative dimensions for the text. These two aspects can be improved.
@prmr prmr added refactoring A proposal to refector or generally improve the code main Issues with the main code base labels Feb 12, 2021
@prmr prmr added this to the Release 3.2 milestone Feb 12, 2021
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 12, 2021
@yannsartori
prmr#413 Create FontMetrics class
ef4c020
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 12, 2021
@yannsartori
prmr#413 Utilize FontMetrics class
e7fb585
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 12, 2021
@yannsartori
prmr#413 Fix the tests that were failing from the changes in TextBoun…
40fb699 
…dsType
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 12, 2021
@yannsartori
prmr#413 Add tests for FontMetrics
a9598e5
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 12, 2021
@yannsartori
prmr#413 Remove irrelevant methods
1934440
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 15, 2021
@yannsartori
prmr#413 Address PR comments
90f6d9f
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Create FontMetrics class
a2ed4fb
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Utilize FontMetrics class
189b7d0
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Fix the tests that were failing from the changes in TextBoundsType
cbd44fc
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Add tests for FontMetrics
1d8d45c
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Remove irrelevant methods
08860cf
prmr pushed a commit that referenced this issue Feb 16, 2021
@yannsartori @prmr
#413 Address PR comments
1be419a
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 16, 2021
@yannsartori
prmr#413 Fix tests that failed due to switch from cast to round
5690767
prmr added a commit that referenced this issue Feb 16, 2021
@prmr
#413 Remove unnecessary casts
3831982
yannsartori added a commit to yannsartori/JetUML that referenced this issue Feb 16, 2021
@yannsartori
prmr#413 Fix tests that failed due to switch from cast to round (on Mac)
76ace0a
prmr pushed a commit that referenced this issue Feb 17, 2021
@yannsartori @prmr
#413 Fix tests that failed due to switch from cast to round (on Mac)
f9f7f1f
prmr added a commit that referenced this issue Feb 18, 2021
@prmr
#413 Fix geometry tests for windows
59dd9d7
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Create FontMetrics class
78a2edc
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Utilize FontMetrics class
f2f3caa
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Fix the tests that were failing from the changes in TextBoun…
491b0a2 
…dsType
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Add tests for FontMetrics
7cae768
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Remove irrelevant methods
1c4371e
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Address PR comments
a61eef7
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@prmr @Farihatanjin
prmr#413 Remove unnecessary casts
932b501
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@yannsartori @Farihatanjin
prmr#413 Fix tests that failed due to switch from cast to round (on Mac)
e8631d7
Farihatanjin pushed a commit to Farihatanjin/JetUML that referenced this issue Feb 23, 2021
@prmr @Farihatanjin
prmr#413 Fix geometry tests for windows
0f538de
@prmr prmr closed this as completed Mar 17, 2021
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Create FontMetrics class
36139f3
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Utilize FontMetrics class
49435c1
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Fix the tests that were failing from the changes in TextBoun…
17500c0 
…dsType
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Add tests for FontMetrics
0c3e868
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Remove irrelevant methods
3d8e901
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Address PR comments
9c915c9
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@prmr @louib
prmr#413 Remove unnecessary casts
6e95d3e
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#413 Fix tests that failed due to switch from cast to round (on Mac)
c53571c
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@prmr @louib
prmr#413 Fix geometry tests for windows
9a7d177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@prmr