Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code involving text to use StringViewer #422

Closed
yannsartori opened this issue Mar 10, 2021 · 0 comments
Closed

Refactor code involving text to use StringViewer #422

yannsartori opened this issue Mar 10, 2021 · 0 comments
Assignees
@yannsartori
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Milestone
Release 3.2

Comments

@yannsartori
Copy link
Contributor

Currently, there are a couple classes that contain operations involving text (AbstractEdgeViewer, StateTransitionEdgeViewer, etc) which all reimplement functionalities provided by StringViewer. These areas can be rewritten to utilize StringViewer

The result of this refactoring would make adding features involving text much easier, since there is only one point of contact.
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 11, 2021
@yannsartori
prmr#422 Make StringViewer flyweight, constructor use EnumSet, option…
b3679f6 
…al pads

Now, instead of passing in a somewhat cryptic sequence of boolean flags
to indicate the decorations, the using code passes in an EnumSet of the
decorations desired. Furthermore, padding is now optional
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 11, 2021
@yannsartori
prmr#422 Update classes to rely on StringViewer
1156e2e
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 11, 2021
@yannsartori
prmr#422 Update StringViewer constructor to reflect new instantiation
5438ba3
@prmr prmr added main Issues with the main code base refactoring A proposal to refector or generally improve the code labels Mar 11, 2021
@prmr prmr added this to the Release 3.2 milestone Mar 11, 2021
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 12, 2021
@yannsartori
prmr#422 Update StringViewer's alignment representations and its cons…
7a8c3d6 
…tructor
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 12, 2021
@yannsartori
prmr#422 Update classes' to reflect new StringViewer constructor
193b5ca
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 12, 2021
@yannsartori
prmr#422 Change cache to be multilevel map; Add utility methods to Al…
9d6e39c 
…ignment
yannsartori added a commit to yannsartori/JetUML that referenced this issue Mar 14, 2021
@yannsartori
prmr#422 Add tests for StringViewer
6b8fb74
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Make StringViewer flyweight, constructor use EnumSet, optional pads
02b522f 
Now, instead of passing in a somewhat cryptic sequence of boolean flags
to indicate the decorations, the using code passes in an EnumSet of the
decorations desired. Furthermore, padding is now optional
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Update classes to rely on StringViewer
d3b4922
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Update StringViewer constructor to reflect new instantiation
947aede
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Update StringViewer's alignment representations and its constructor
f7b1306
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Update classes' to reflect new StringViewer constructor
903bffc
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Change cache to be multilevel map; Add utility methods to Alignment
77aafe7
prmr pushed a commit that referenced this issue Mar 16, 2021
@yannsartori @prmr
#422 Add tests for StringViewer
6a44daf
prmr added a commit that referenced this issue Mar 16, 2021
@prmr
#422 Fix tests for Windows
093f28c
@prmr prmr closed this as completed Mar 16, 2021
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Make StringViewer flyweight, constructor use EnumSet, option…
65c80dd 
…al pads

Now, instead of passing in a somewhat cryptic sequence of boolean flags
to indicate the decorations, the using code passes in an EnumSet of the
decorations desired. Furthermore, padding is now optional
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Update classes to rely on StringViewer
44b3fe3
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Update StringViewer constructor to reflect new instantiation
b510d79
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Update StringViewer's alignment representations and its cons…
a1c6da9 
…tructor
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Update classes' to reflect new StringViewer constructor
667d7d3
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Change cache to be multilevel map; Add utility methods to Al…
967fee2 
…ignment
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@yannsartori @louib
prmr#422 Add tests for StringViewer
47302a5
louib pushed a commit to louib/JetUML that referenced this issue Aug 15, 2021
@prmr @louib
prmr#422 Fix tests for Windows
fa2e300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannsartori yannsartori

Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
2 participants
@prmr @yannsartori