Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the Edge Label Alignments #446

Closed
delphinepilon opened this issue Nov 17, 2021 · 1 comment
Closed

Improvements to the Edge Label Alignments #446

delphinepilon opened this issue Nov 17, 2021 · 1 comment
Assignees
@delphinepilon
Labels
feature A feature request main Issues with the main code base
Milestone
Release 3.4

Comments

@delphinepilon
Copy link
Contributor

Some points could be improved in the layout and alignment of edge labels:

  1. In the state diagrams, state transition edges have a fixed line length when there are multiple words in the edge label. This can be inconvenient as it is less flexible than dynamic line lengths.
FixedLineLength.mov
  1. In class diagrams, segmented edges can have three labels. For horizontal segmented edges, the labels that are closest to the nodes are slightly shifted away from the node to clear the arrowhead. This is not the case for vertical segmented edges. Here, by horizontal segmented edge, I mean that the majority of segments are horizontal.

LackOfLabelAndArrowheadOverlap

  1. In class diagrams, the middle label of segmented edges can sometimes overlap the segments themselves which is not ideal as it can make the labels less readable.

LabelAndSegmentOverlap
@prmr prmr added feature A feature request main Issues with the main code base labels Dec 16, 2021
@prmr prmr added this to the Release 3.4 milestone Dec 16, 2021
prmr added a commit that referenced this issue Dec 16, 2021
@prmr
#446 Update tests so they pass on Windows
e890d3f 
The test for the visual layout of #446 were developed on Mac, and
Windows has a slightly different font size, so test oracles that are
close to the boundary will be flaky.
@prmr
Copy link
Owner

prmr commented Dec 16, 2021

Fixed with PR #447

@prmr prmr closed this as completed Dec 16, 2021
prmr added a commit that referenced this issue Jan 3, 2022
@prmr
#446 Fix Checkstyle warnings
c805d1d
prmr added a commit that referenced this issue Jan 18, 2022
@prmr
#446 Use default font size in font-sensitive tests
ef599d8 
Some tests of the diagram layout are sensitive to the font size. The
font size is stored in the system properties. Before the test, we cache
the current font size, then set the default one for the tests, and
restore the user's font size once the tests are over.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delphinepilon delphinepilon

Labels
feature A feature request main Issues with the main code base
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
2 participants
@prmr @delphinepilon