Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor access to viewing logic #466

Closed
prmr opened this issue Jun 6, 2022 · 0 comments
Closed

Refactor access to viewing logic #466

prmr opened this issue Jun 6, 2022 · 0 comments
Assignees
@prmr
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Milestone
Release 3.5

Comments

@prmr
Copy link
Owner

prmr commented Jun 6, 2022

The various accesses to objects in charge of viewing diagrams and diagram elements is getting unprincipled due to the growing number of per-diagram special cases and optimizations. This should be collected under a single facade.
@prmr prmr self-assigned this Jun 6, 2022
@prmr prmr added refactoring A proposal to refector or generally improve the code main Issues with the main code base labels Jun 6, 2022
@prmr prmr added this to the Release 3.5 milestone Jun 6, 2022
prmr added a commit that referenced this issue Jun 7, 2022
@prmr
Issue #466 Move createIcon to RenderingFacade
cf513dc 
This convenience method was arbitrarily placed in a utility class where
it did not really belong.
prmr added a commit that referenced this issue Jun 7, 2022
@prmr
Issue #466 Move getSelectedBounds to RenderingFacade
06875c1 
First step in removing any computation involving rendering out of the
SelectionModel.
prmr added a commit that referenced this issue Jun 7, 2022
@prmr
Issue #466 Move bounds-related method to RenderingFacade
d79f928 
With this commit, the SelectionModel class is no longer responsible for
computing bounds.
@prmr prmr closed this as completed Jul 13, 2022
prmr added a commit that referenced this issue Jul 15, 2022
@prmr
Issue #466 Fix regression bug
1f2efe3 
The initialization statements in DiagramCanvas had been reordered and
the canvas dimension in DiagramBuilder was set using the size of the
canvas, because the canvas size was set. As a result, the Builder always
thought the Canvas size was 0x0.
@prmr prmr mentioned this issue Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prmr prmr

Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Projects
None yet
Milestone
Release 3.5
Development

No branches or pull requests
1 participant
@prmr