Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small visual glitch with aggregation line in class diagram #474

Closed
cjoudrey opened this issue Oct 19, 2022 · 1 comment
Closed

Small visual glitch with aggregation line in class diagram #474

cjoudrey opened this issue Oct 19, 2022 · 1 comment
Assignees
@prmr
Labels
main Issues with the main code base visuals Improvements to the general look and style of the diagrams
Milestone
Release 3.6

Comments

@cjoudrey
Copy link

Description

I was in the process of drawing a class diagram with two arrows pointing between two objects and noticed a slight visual glitch.

It's not a big deal, but I figured I'd open an issue in case it is a low hanging fruit.

Screenshots

Notice how the aggregate line isn't fully straight:

Screen Shot 2022-10-19 at 1 55 14 PM

Configuration

  • JetUML Release: 3.4
  • OS + version: macOS 12.6
  • Java version: 17.0.4.1
@prmr prmr added main Issues with the main code base visuals Improvements to the general look and style of the diagrams labels Oct 25, 2022
@prmr prmr added this to the Release 3.6 milestone Dec 5, 2022
@prmr prmr self-assigned this Jun 29, 2023
@prmr
Copy link
Owner

prmr commented Jun 30, 2023 •
edited
Loading

The root cause is the specification of the behavior of NodeIndex#toPoint, which computes attachment points on a node face attempting to maximize the space available on the attached face of the node. As observed, the excess precision can lead to a suboptimal look.

I will change the function so that the outcome is more visually pleasing.

@prmr prmr closed this as completed Jun 30, 2023
prmr added a commit that referenced this issue Jul 10, 2023
@prmr
Issue #474 Cosmetic and documentation changes
dd00558
prmr added a commit that referenced this issue Jul 10, 2023
@prmr
Issue #474 Change return value of spaceBetweenConnectionPoints to int
7e4315c 
There was no reasons to use a float there, since we are dealing with a
space in pixels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prmr prmr

Labels
main Issues with the main code base visuals Improvements to the general look and style of the diagrams
Projects
None yet
Milestone
Release 3.6
Development

No branches or pull requests
2 participants
@cjoudrey @prmr