Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification-based Feedback Mechanism #508

Closed
5 tasks done
ArthusWQZ opened this issue Oct 7, 2023 · 0 comments
Closed
5 tasks done

Notification-based Feedback Mechanism #508

ArthusWQZ opened this issue Oct 7, 2023 · 0 comments
Labels
feature A feature request main Issues with the main code base
Milestone
Release 3.7

Comments

@ArthusWQZ
Copy link
Contributor

ArthusWQZ commented Oct 7, 2023 •
edited by prmr
Loading

Implement a non-obtrusive notification-based feedback mechanism using toast notifications.

GUI part

  • Implement the Notification interface
  • Implement the notification handling logic in the EditorFrame class
  • Implement the ToastNotification class
  • Add a dialog to allow user to set notification time, or disable it
  • Add a tip to describe this feature

Functional part

Identify unvalidated semantic constraint to display a notification to the user with an explanation as to why the semantic constraint was broken.
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
prmr#508 Built Notification interface scaffolding
c756391
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
prmr#508 Built NotificationHandler class with basic singleton require…
c03af4f 
…ments
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
prmr#508 Minor style changes
305a4bb
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Added cleanup callback when notification lifetime ends
879ec75
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Added cleanup callback support to Notification interface
de5049b
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Created ToastNotification class with stage initialization …
efd1182 
…and animation
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Minor style changes
9759ea8
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Added height getter for notifications
b2dd94d
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 16, 2023
@ArthusWQZ
[prmr#508] Added notification spawning and rearranging methods
e57b602
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
prmr#508 Built Notification interface scaffolding
4746930
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
prmr#508 Built NotificationHandler class with basic singleton require…
f4f404a 
…ments
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
prmr#508 Minor style changes
c360034
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added cleanup callback when notification lifetime ends
41c107b
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added cleanup callback support to Notification interface
8b04b96
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Created ToastNotification class with stage initialization …
0a2f764 
…and animation
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Minor style changes
26c7136
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added height getter for notifications
6521f9f
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added notification spawning and rearranging methods
c35eaf2
@prmr prmr added feature A feature request main Issues with the main code base labels Oct 17, 2023
@prmr prmr added this to the Release 3.7 milestone Oct 17, 2023
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Updated handler spawning method to support polymorphism
176e244
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Updated handler spawning method to support polymorphism
b6989d9
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added handler initialization on start
f262e5a
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 17, 2023
@ArthusWQZ
[prmr#508] Added window position listener for notification anchoring
6036416
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 18, 2023
@ArthusWQZ
[prmr#508] Added Toast types and added constructor for manual instant…
d4b5ddd 
…iation
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 18, 2023
@ArthusWQZ
[prmr#508] Added success toast when copying to clipboard
771a245
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 18, 2023
@ArthusWQZ
[prmr#508] Added license info
87dabf5
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 23, 2023
@ArthusWQZ
[prmr#508] Added test file with handler unit tests
779aee2
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Oct 24, 2023
@ArthusWQZ
[prmr#508] Added support for custom animation delays and lifespan for…
ee2d6d3 
… toasts
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Converted edge constraint methods to classes in their own file
f3b3459
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Updated constraint constructor access modifiers
abb4ac1
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Style improvements
f60bb27
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Removed edge constraint methods and updated design with new im…
9d47b32 
…plementation of constraints
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Added notification spawning when edge constraint is invalidated
04be674
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Moved NotificationHandler configuration to main JetUML file
044b732
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Minor refactoring and polishing: renamed to NotificationServic…
5c5887b 
…e, style improvements, more detailed comments
prmr pushed a commit that referenced this issue Dec 5, 2023
@ArthusWQZ @prmr
[#508] Added a few tests
04a817e
prmr added a commit that referenced this issue Dec 5, 2023
@prmr
[#508] Remove unused imports and suppress type warnings
6784d94
prmr added a commit that referenced this issue Dec 5, 2023
@prmr
[#508] Disable hanging test
dde9c20
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 6, 2023
@ArthusWQZ
[prmr#508] Disabled JavaFX Application Thread implicit exit, fixing t…
d63f0a6 
…he hanging test issue
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 6, 2023
@ArthusWQZ
[prmr#508] Enabled TestSemanticErrorNotification since it doesn't han…
3cd9079 
…g anymore, style improvements
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 6, 2023
@ArthusWQZ
[prmr#508] Notifications are now repositioned when the window is resi…
8c701bf 
…zed, fixed window flickering bug
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 6, 2023
@ArthusWQZ
[prmr#508] Moved window transformation listener to NotificationServic…
4fc4f46 
…e class
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 6, 2023
@ArthusWQZ
[prmr#508] Added and updated tests
cf22508
ArthusWQZ added a commit to ArthusWQZ/JetUML that referenced this issue Dec 8, 2023
@ArthusWQZ
[prmr#508] Added notification limit when overshooting the main window…
0886307 
…, improved testing speed
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Disabled JavaFX Application Thread implicit exit, fixing the h…
ffed210 
…anging test issue
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Enabled TestSemanticErrorNotification since it doesn't hang an…
9f5a6a6 
…ymore, style improvements
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Notifications are now repositioned when the window is resized,…
1d9cf50 
… fixed window flickering bug
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Moved window transformation listener to NotificationService class
c0a0592
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Added and updated tests
ba3edf2
prmr pushed a commit that referenced this issue Dec 18, 2023
@ArthusWQZ @prmr
[#508] Added notification limit when overshooting the main window, im…
fc1a758 
…proved testing speed
prmr added a commit that referenced this issue Dec 18, 2023
@prmr
[#508] Fix warnings
c13aae0
prmr added a commit that referenced this issue Dec 19, 2023
@prmr
[#508] Fix typo in resource name.
61c31ff
@prmr prmr closed this as completed Jan 8, 2024
@prmr prmr reopened this Jan 8, 2024
@prmr prmr mentioned this issue Jan 8, 2024
Closed
@prmr prmr closed this as completed Jan 8, 2024
prmr added a commit that referenced this issue Jan 8, 2024
@prmr
[#508] Decrease visibility of methods in test class.
019c252
prmr added a commit that referenced this issue Jan 8, 2024
@prmr
[#508] Small refactorings
5e8dbf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A feature request main Issues with the main code base
Projects
None yet
Milestone
Release 3.7
Development

No branches or pull requests
2 participants
@prmr @ArthusWQZ