Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run geometry tests only on windows #542

Closed
prmr opened this issue May 6, 2024 · 0 comments
Closed

Run geometry tests only on windows #542

prmr opened this issue May 6, 2024 · 0 comments
Assignees
Labels
refactoring A proposal to refector or generally improve the code tests Issues with test code and resources
Milestone

Comments

@prmr
Copy link
Owner

prmr commented May 6, 2024

The geometry tests ensure that the diagram renders properly. For this purpose it uses pixel coordinates. Because of system fonts and other environment configuration details, these coordinates vary from OS to OS. The current solution is to add values for all 3 main OSes, which is extremely cumbersome and does not provide much value because the underlying geometry calculations are OS-independent. Instead, we will run the tests only on Windows.

@prmr prmr self-assigned this May 6, 2024
@prmr prmr added refactoring A proposal to refector or generally improve the code tests Issues with test code and resources labels May 6, 2024
@prmr prmr added this to the Release 3.8 milestone May 6, 2024
@prmr prmr closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A proposal to refector or generally improve the code tests Issues with test code and resources
Projects
None yet
Development

No branches or pull requests

1 participant