Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection point calculation error in State Transition Diagram #547

Closed
prmr opened this issue May 9, 2024 · 1 comment
Closed

Connection point calculation error in State Transition Diagram #547

prmr opened this issue May 9, 2024 · 1 comment
Labels
bug A problem main Issues with the main code base
Milestone
Release 3.8

Comments

@prmr
Copy link
Owner

prmr commented May 9, 2024

Description
When rendering two transition edges between two state nodes, if one of the nodes is in a very specific position in relation to the other node, the connection point for one of the two edges will be located at an incorrect position within the node. This can be observed for the bottom two corners.

Steps to reproduce

  1. Create new State diagram .
  2. Create two state nodes, join them by two edges in the same direction.
  3. Carefully rotate one node around the other. The misplaced connection point can be observed by the edge flashing when the node is in the precise problematic position.

Screenshots
image

Configuration

  • JetUML Release: 3.7

Additional information
Probably an issue in StateTransitionEdgeRenderer
@prmr prmr added bug A problem main Issues with the main code base labels May 9, 2024
@prmr prmr added this to the Release 3.8 milestone May 9, 2024
@jkcoding7
Copy link
Contributor

jkcoding7 commented May 10, 2024 •
edited
Loading

It appears that the incorrect position can occur at either connection point of the edge, but always in the north-west and north-east directions:

image

jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue May 15, 2024
@jkcoding7
[prmr#547] Fix connection point for edges in State Diagrams
204754d
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue May 15, 2024
@jkcoding7
[prmr#547] Fix connection point for edges in State Diagrams
2816e59
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue May 16, 2024
@jkcoding7
[prmr#547] Update tests to include intersection at rectangle corners.
ca55276
prmr pushed a commit that referenced this issue May 21, 2024
@jkcoding7 @prmr
[#547] Fix connection point for edges in State Diagrams
7d4792c
prmr pushed a commit that referenced this issue May 21, 2024
@jkcoding7 @prmr
[#547] Update tests to include intersection at rectangle corners.
7f98abc
@prmr prmr closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem main Issues with the main code base
Projects
None yet
Milestone
Release 3.8
Development

No branches or pull requests
2 participants
@prmr @jkcoding7