Initialization routines for ODE filters #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnkraemer
added
refactoring
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 86.40% 86.48% +0.07%
==========================================
Files 124 125 +1
Lines 5465 5489 +24
Branches 725 725
==========================================
+ Hits 4722 4747 +25
+ Misses 514 513 -1
Partials 229 229
|
pnkraemer
commented
Jul 17, 2021
pnkraemer
commented
Jul 17, 2021
pnkraemer
commented
Jul 17, 2021
Comment on lines
96
to
98
| def __call__( | ||
| self, ivp: problems.InitialValueProblem, prior_process: randprocs.MarkovProcess | ||
| ) -> randvars.RandomVariable: |
There was a problem hiding this comment.
please let me know if the changed naming (and some reordering) makes it easier to understand what this code does :)
pnkraemer
commented
Jul 17, 2021
nathanaelbosch
requested changes
Jul 19, 2021
tests/test_diffeq/test_odefiltsmooth/test_initialize/test_taylor_mode.py
Outdated
Show resolved
Hide resolved
nathanaelbosch
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR introduces an interface for initialization routines in ODE filters.
Detailed Description
See above. This PR also cleans up the tests for initialization routines and updates some docs. Taylor-mode AD code is cleaned up slightly.
The concept is very similar to what happens in #486, but since the content is sufficiently orthogonal, I made a new PR.