Skip to content

Commit

Permalink
Merge branch 'main' into 412-user-guide-and-api-documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
sylvaincom committed Oct 21, 2024
2 parents a8e77fe + f514d06 commit a7ef55a
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ python -m skore launch "project.skore"
```
This will automatically open a browser at the UI's location:
1. On the top left, create a new `View`.
2. From the `Elements` section on the bottom left, you can add stored items to this view, either by double-cliking on them or by doing drag-and-drop.
2. From the `Items` section on the bottom left, you can add stored items to this view, either by double-cliking on them or by doing drag-and-drop.

## 👨‍💻 More examples

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function onItemSelected(key: string) {

<template>
<div class="keys-list">
<SectionHeader title="Elements" icon="icon-pie-chart" />
<SectionHeader title="Items" icon="icon-pie-chart" />
<Simplebar class="scrollable">
<TreeAccordion :nodes="projectStore.keysAsTree()" @item-selected="onItemSelected" />
</Simplebar>
Expand Down
4 changes: 2 additions & 2 deletions skore-ui/src/views/project/ProjectView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { fetchShareableBlob } from "@/services/api";
import { saveBlob } from "@/services/utils";
import { useProjectStore } from "@/stores/project";
import { useToastsStore } from "@/stores/toasts";
import ProjectElementList from "@/views/project/ProjectElementList.vue";
import ProjectItemList from "@/views/project/ProjectItemList.vue";
import ProjectViewList from "@/views/project/ProjectViewList.vue";
const props = defineProps({
Expand Down Expand Up @@ -81,7 +81,7 @@ onBeforeUnmount(() => {
<main class="project-view" v-if="projectStore.items !== null">
<div class="left-panel" v-if="projectStore.items && !isInFocusMode">
<ProjectViewList />
<ProjectElementList />
<ProjectItemList />
</div>
<div ref="editor" class="editor">
<div class="editor-header">
Expand Down
2 changes: 1 addition & 1 deletion skore-ui/tests/components/DataFrameWidget.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe("DataFrameWidget", () => {
expect(wrapper.findAll("tbody > tr").length).toBe(props.data.length);
});

it("Computes elements correctly.", () => {
it("Computes rows correctly.", () => {
const props = generateFakeProps(500);
const wrapper = mountComponent(props);

Expand Down
6 changes: 6 additions & 0 deletions skore/tests/unit/test_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,15 @@ def test_load(tmp_path):
os.mkdir(project_path)
os.mkdir(project_path / "items")
os.mkdir(project_path / "views")

p = load(project_path)
assert isinstance(p, Project)

# Test without `.skore`
os.chdir(tmp_path.parent)
p = load(tmp_path.name)
assert isinstance(p, Project)


def test_put(in_memory_project):
in_memory_project.put("key1", 1)
Expand Down

0 comments on commit a7ef55a

Please sign in to comment.