Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define our commit naming convention and automate its verification #66

Closed
thomass-dev opened this issue Jul 23, 2024 · 3 comments · Fixed by #398
Closed

Define our commit naming convention and automate its verification #66

thomass-dev opened this issue Jul 23, 2024 · 3 comments · Fixed by #398
Labels
chore Internal enhancement work to be done question Further information is requested

Comments

@thomass-dev
Copy link
Collaborator

thomass-dev commented Jul 23, 2024 •
edited
Loading

conventionalcommits seems to be a standard.
We can automate its verification using a pre-commit hook or commitlint ?

If we allow merge commits, this verification is necessary on each commits of a PR + PR title.
If we only allow squash-merging, this verification is only necessary on the PR title.
@thomass-dev thomass-dev added the question Further information is requested label Jul 23, 2024
@thomass-dev thomass-dev changed the title Define our commit naming convention and automatise checks in CI Define our commit naming convention and automate its verification Jul 23, 2024
@tuscland tuscland added the chore Internal enhancement work to be done label Sep 17, 2024
@tuscland
Copy link
Member

Is it related to #398?

@thomass-dev
Copy link
Collaborator Author

Is it related to #398?

Yes but its not sufficient imho.

@tuscland
Copy link
Member

Kindly explain why, or/and update the description so we keep a clear shared understanding of what is needed. I would prefer not have to guess this is more work for my brain! 😉

@tuscland tuscland mentioned this issue Sep 30, 2024
Merged
thomass-dev pushed a commit that referenced this issue Oct 1, 2024
@augustebaum
ci: Enforce conventional commit format in PR title (#398)
7f9d5a8 
Closes #66
thomass-dev pushed a commit that referenced this issue Dec 2, 2024
@augustebaum
ci: Enforce conventional commit format in PR title (#398)
5eb03e2 
Closes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Internal enhancement work to be done question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Enforce conventional commit format in PR title probabl-ai/skore
2 participants
@tuscland @thomass-dev