Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression : MediaItem with text/html media type does not appear correctly in skore UI #823

Closed
rouk1 opened this issue Nov 27, 2024 · 1 comment · Fixed by #828
Closed
Labels
bug Something isn't working

Comments

@rouk1
Copy link
Contributor

rouk1 commented Nov 27, 2024

Describe the bug

Skrub table report appears as a base 64 string.
Screenshot 2024-11-27 at 17 19 07

Steps/Code to Reproduce

from skore import create
from skrub import TableReport
from skrub.datasets import fetch_employee_salaries

p = create("toto", overwrite=True)
df = fetch_employee_salaries().X
report = TableReport(df)
p.put("large table report", report)
skore launch toto

Expected Behavior

Table report should appear and be interactive.

Actual Behavior

TabelReport appears a sa base64 string.

Environment

System:
    python: 3.12.7 (main, Oct  1 2024, 02:05:46) [Clang 15.0.0 (clang-1500.3.9.4)]
executable: /Users/rouk1/dev/skore/venv/bin/python
   machine: macOS-14.6.1-arm64-arm-64bit

Python dependencies:
        skore: 0.0.0+unknown
          pip: 24.2
   setuptools: None
    diskcache: 5.6.3
      fastapi: 0.115.5
 plotly<6,>=5: None
      pyarrow: 18.1.0
         rich: 13.9.4
        skops: 0.10.0
      uvicorn: 0.32.1
@rouk1 rouk1 added bug Something isn't working needs-triage This has been recently submitted and needs attention labels Nov 27, 2024
@rouk1
Copy link
Contributor Author

rouk1 commented Nov 28, 2024

Note: this happens for all media items with text/html media type.

@rouk1 rouk1 changed the title Skrub table report does not appear correctly in skore UI regression : MediaItem with text/html media type does not appear correctly in skore UI Nov 28, 2024
@rouk1 rouk1 removed the needs-triage This has been recently submitted and needs attention label Nov 28, 2024
@rouk1 rouk1 changed the title regression : MediaItem with text/html media type does not appear correctly in skore UI Regression : MediaItem with text/html media type does not appear correctly in skore UI Nov 28, 2024
@rouk1 rouk1 linked a pull request Nov 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant