feat(api): Allow to flatten index in reports #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for backend
|
|
I change a bit the rule to not have any upper case, spaces and hash characters and replace with lower case, underscore, and nothing, respectively. It would be the type of naming that I would use if I want to index a dataframe. I documented this behaviour in the different docstrings. |
probabl-ai#1286) - [x] Rename to `ComparisonReport` - [x] Rebase on top of probabl-ai#1239 and adapt - [x] Raise if `report.metrics.accuracy(data_source="train")` is called with at least one EstimatorReport that does not have training data - [x] Test - [x] Docstrings - [x] MetricsAccessor - [x] Move index column "#0" in front of each metric - [x] Pass report names in comparator - [ ] ~Update plots legend~ see probabl-ai#1309 - The actual `RocCurveDisplay` needs a full refactor to be splitted by use-case: estimator report, cross-validation report and finally comparison report. In each of these use-cases, there is two scenarios with binary classification and multi-class classification. Otherwise, it will be unmaintainable. - [ ] ~Investigate missing metrics in `report_metrics`~ **(deferred to future PR)** - The logic is split between `report_metrics` and `available_if`; it should be merged (ideally everything in `available_if`?) - [ ] ~Refactor to make `CrossValidationReport` depend on it~ **(deferred to future PR)** - [x] ~Change EstimatorReport `repr`?~ Issue probabl-ai#1293 Closes probabl-ai#1245 Co-authored-by: Auguste <auguste@probabl.ai> Co-authored-by: Sylvain Combettes <48064216+sylvaincom@users.noreply.github.com>
…obabl-ai#1322) `project.clear(delete_project=True)` now deletes the entire project, while `project.clear(delete_project=False)` (the default) removes every item from the project. Closes probabl-ai#1294
|
Time to rebase ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1271
Add a parameter to allow to get a flat index to ease indexing.