Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of pandas.Series #378

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Support of pandas.Series #378

merged 2 commits into from
Sep 24, 2024

Conversation

thomass-dev
Copy link
Collaborator

No description provided.

@thomass-dev thomass-dev linked an issue Sep 23, 2024 that may be closed by this pull request
@thomass-dev thomass-dev force-pushed the 356-putting-series-in-project branch 2 times, most recently from 7a61b10 to ea45e19 Compare September 23, 2024 15:14
@thomass-dev thomass-dev marked this pull request as ready for review September 23, 2024 15:28
src/skore/item/pandas_series_item.py Outdated Show resolved Hide resolved
Fix docstring

Co-authored-by: Auguste Baum <52001167+augustebaum@users.noreply.github.com>
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we store a plotted representation of the series ? The markdow layout will be bad especially for large series.
Pandas offers this with a default matplotlib backend (which is supported by the frontend).

@sylvaincom
Copy link
Contributor

I often use the plot method of pandas, very convenient for one line code; otherwise using matplotlib or plotly to (re)plot a series is fine

@thomass-dev
Copy link
Collaborator Author

Could we store a plotted representation of the series ? The markdow layout will be bad especially for large series. Pandas offers this with a default matplotlib backend (which is supported by the frontend).

I think its hard to find a generic plot which can represent all sort of series, while remaining easy to understand.
Maybe we can just display a sample of the series when its too long ? As done by pandas in python (0, 1, 2, [...], 3, 4).

@rouk1 is there the same problem on list-primitive type?
@MarieS-WiMLDS @sylvaincom what do you think?

Keep in mind that, as for python list, the user can put whatever he wants in his series (str, number, str & number etc).

@MarieS-WiMLDS
Copy link
Contributor

MarieS-WiMLDS commented Sep 24, 2024

Maybe we can just display a sample of the series when its too long ? As done by pandas in python

It seems a good idea to me!

@rouk1
Copy link
Contributor

rouk1 commented Sep 24, 2024

I think its hard to find a generic plot which can represent all sort of series, while remaining easy to understand. Maybe we can just display a sample of the series when its too long ? As done by pandas in python (0, 1, 2, [...], 3, 4).

@rouk1 is there the same problem on list-primitive type? @MarieS-WiMLDS @sylvaincom what do you think?

Keep in mind that, as for python list, the user can put whatever he wants in his series (str, number, str & number etc).

Ok then we need to update how the frontend displays native object.
I've create an issue for that.

@augustebaum augustebaum merged commit 3749ca7 into main Sep 24, 2024
3 checks passed
@augustebaum augustebaum deleted the 356-putting-series-in-project branch September 24, 2024 13:49
thomass-dev added a commit that referenced this pull request Dec 2, 2024
Co-authored-by: Auguste Baum <52001167+augustebaum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Putting Series in Project
6 participants