-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SklearnBaseEstimatorItem): Temporarily disable skops's security feature #420
Conversation
Coverage Report for ./frontend
File CoverageNo changed files found. |
SklearnBaseEstimatorItem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me but I do not know how to build a "unsafe" estimator.
Please @tuscland can you take a look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall that's looking great, however I would like to see a test succeeding in the case of an otherwise untrusted estimator.
…eature (#420) Based on the skops tutorial: https://skops.readthedocs.io/en/stable/persistence.html#usage.
Based on the skops tutorial: https://skops.readthedocs.io/en/stable/persistence.html#usage.