Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(launch): Replace thread with lifespan event for opening the browser #421

Merged
merged 1 commit into from
Oct 1, 2024
Merged

refactor(launch): Replace thread with lifespan event for opening the browser #421

merged 1 commit into from
Oct 1, 2024

Conversation

augustebaum
Copy link
Contributor

@augustebaum augustebaum commented Oct 1, 2024 •
edited
Loading

Closes #301

@augustebaum augustebaum requested a review from rouk1 October 1, 2024 14:27
rouk1
rouk1 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice : )

@rouk1 rouk1 merged commit 188b502 into main Oct 1, 2024
6 checks passed
@rouk1 rouk1 deleted the lifespan branch October 1, 2024 14:43
thomass-dev pushed a commit that referenced this pull request Dec 2, 2024
@augustebaum
refactor(launch): Replace thread with lifespan event for opening the …
75f99bd 
…browser (#421)

Closes #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouk1 rouk1 rouk1 approved these changes

Assignees

@augustebaum augustebaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webapp launcher page
3 participants
@augustebaum @rouk1 @auguste-probabl