Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a convenient way of outputting system and dependency versions (#425) #426

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat: Add a convenient way of outputting system and dependency versions (#425) #426

merged 3 commits into from
Oct 3, 2024

Conversation

tuscland
Copy link
Member

@tuscland tuscland commented Oct 2, 2024

No description provided.

@tuscland tuscland linked an issue Oct 2, 2024 that may be closed by this pull request
Add a convenient way of outputting system and dependency versions #425
Closed
@tuscland tuscland force-pushed the 425-add-a-convenient-way-of-outputting-system-and-dependency-versions branch 3 times, most recently from 87ebfff to 7d0ad05 Compare October 2, 2024 14:18
@tuscland tuscland marked this pull request as ready for review October 2, 2024 14:19
@tuscland tuscland force-pushed the 425-add-a-convenient-way-of-outputting-system-and-dependency-versions branch from 7d0ad05 to 0e055bc Compare October 2, 2024 14:22
@tuscland tuscland mentioned this pull request Oct 2, 2024
Merged
rouk1
rouk1 requested changes Oct 2, 2024
View reviewed changes
src/skore/utils/_show_versions.py Outdated Show resolved Hide resolved
@tuscland tuscland force-pushed the 425-add-a-convenient-way-of-outputting-system-and-dependency-versions branch from 0e055bc to bc303a0 Compare October 2, 2024 15:17
rouk1
rouk1 requested changes Oct 2, 2024
View reviewed changes
src/skore/utils/_show_versions.py Outdated Show resolved Hide resolved
@rouk1
Copy link
Contributor

rouk1 commented Oct 3, 2024

The _get_deps_info function now uses importlib instead of parsing the pyproject.
co-autorhed with @thomass-dev

@rouk1 rouk1 merged commit c27ba8f into main Oct 3, 2024
3 checks passed
@rouk1 rouk1 deleted the 425-add-a-convenient-way-of-outputting-system-and-dependency-versions branch October 3, 2024 08:37
@tuscland
Copy link
Member Author

tuscland commented Oct 3, 2024

You are the best @rouk1 @thomass-dev

thomass-dev pushed a commit that referenced this pull request Dec 2, 2024
@tuscland @rouk1
feat: Add a convenient way of outputting system and dependency versio…
c8c2acd 
…ns (#425) (#426)

Co-authored-by: Matthieu Jouis <matthieu@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomass-dev thomass-dev thomass-dev approved these changes

@rouk1 rouk1 rouk1 approved these changes

Assignees

@tuscland tuscland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a convenient way of outputting system and dependency versions
3 participants
@tuscland @rouk1 @thomass-dev