Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Add animation frames to plotly widgets #448

Merged

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Oct 7, 2024

Animation frames were ignored in plotly construction. It's now fixed.
Closes #446

@rouk1 rouk1 linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Coverage Report for ./skore-ui

Status Category Percentage Covered / Total
🔵 Lines 79.91% 1464 / 1832
🔵 Statements 79.91% 1464 / 1832
🔵 Functions 44.89% 44 / 98
🔵 Branches 83.87% 130 / 155
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
skore-ui/src/components/PlotlyWidget.vue 100% 100% 100% 100%
Generated in workflow #64 for commit 02f7b77 by the Vitest Coverage Report Action

@thomass-dev thomass-dev merged commit 02510fc into main Oct 7, 2024
9 checks passed
@thomass-dev thomass-dev deleted the 446-plotly-animation-not-supported-in-the-dashboard branch October 7, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotly animation not supported in the dashboard
2 participants