Turn on ruff linter, fix final 7 bugs #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Jul 23, 2024
| @@ -172,9 +172,6 @@ def video_input_from_mp4( | |||
| downsize=1, | |||
| reverse_color_channel=False, | |||
| ): | |||
| if times is None: | |||
There was a problem hiding this comment.
@mirkoklukas , T wasn't available, so we can't do this calculation here; we could pass times back OUT of load_video_to_numpy, but that's a bigger change.
Can you let us know if the below change, where we swap your fps for info.fps, is valid?
There was a problem hiding this comment.
I think adding T = info.timesteps before the None check should do the trick.
georgematheos
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on the linter; we can't merge until we address the final linter bugs.
ruffis enabled as a GitHub Action, so that we see errors in the PRs in github formatrufflocally is added (with the same version) to.pre-commit-config.yml@mirkoklukas , would you mind taking a look at the line that I pointed out in the PR?