Fix bugs in run_tests.sh #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
approved these changes
Jul 23, 2024
|
@georgematheos was there a jitted version we want to add back, or is this not important for the tests? |
|
It looks to me like the non-jitted versions were removed, and the jitted
versions had the phrase “jit” removed from their names. So this should
still be calling the jitted versions.
…On Tue, Jul 23, 2024 at 4:16 PM Sam Ritchie ***@***.***> wrote:
@georgematheos <https://github.com/georgematheos> was there a jitted
version we want to add back, or is this not important for the tests?
—
Reply to this email directly, view it on GitHub
<#79 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD7OROJZZC73S7GMYJT7GYTZN22ZJAVCNFSM6AAAAABLLCXNOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGIZTGNRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sritchie @nishadgothoskar after this change, run_tests.sh passes on my machine.