Skip to content

Commit

Permalink
Fix host-based handler, remove domain mapping script
Browse files Browse the repository at this point in the history
  • Loading branch information
mhuebert committed May 24, 2024
1 parent aaefe6b commit f3c479b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 36 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/publish_website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ jobs:

- name: Deploy to Google Cloud Storage
run: |
gcloud storage rsync --recursive --cache-control 'public, max-age=60' $WEBSITE_DIR gs://gen-website-private/${{github.repository}}
- name: Ensure Domain Mapping
run: |
REPOSITORY_NAME=$(echo $GITHUB_REPOSITORY | cut -d'/' -f2)
./scripts/ensure_domain_mapping.sh ${REPOSITORY_NAME}.gen.dev
gcloud storage rsync --recursive --cache-control 'public, max-age=60' $WEBSITE_DIR gs://gen-website-private/${{github.repository}}
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,7 @@ We will now find in our GCP account:
There is also a second identity pool, `gen-website-private-publishers`, which grants all probcomp repositories access to the private bucket
within GitHub Actions.

Note: using this identity pool, a GitHub action in any probcomp website can modify the `gen-website-private` bucket without restriction.
Note: using this identity pool, a GitHub action in any probcomp website can modify the `gen-website-private` bucket without restriction.

[These instructions](https://gist.github.com/patmigliaccio/d559035e1aa7808705f689b20d7b3fd3) were essential to enabling SSL for a wildcard
subdomain on App Engine.
28 changes: 0 additions & 28 deletions scripts/ensure_domain_mapping.sh

This file was deleted.

2 changes: 1 addition & 1 deletion server.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ app.get('/*', async (req, res) => {
if (match) {
const repo = match[1];
const filePath = req.params[0];
await handleFileRequest(repo, filePath, req, res);
await handleFileRequest(repo, filePath, res);
} else {
res.status(404).send('Not Found');
}
Expand Down

0 comments on commit f3c479b

Please sign in to comment.