Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cloudflare worker to override iap cache headers #4

Merged
merged 2 commits into from
Nov 7, 2024
Merged

add cloudflare worker to override iap cache headers #4

merged 2 commits into from
Nov 7, 2024

Conversation

mhuebert
Copy link
Collaborator

@mhuebert mhuebert commented Nov 7, 2024 •
edited
Loading

  • Fix caching by having a Cloudflare worker add caching headers, which are otherwise stripped by GAE IAP.
  • Modify the App Engine server to proxy all files instead of using signed bucket urls (which don't forward the redirect's cache header nor respect bucket CORS settings)

@mhuebert mhuebert requested a review from sritchie November 7, 2024 12:18
@mhuebert
add cloudflare caching worker
5b1f8a5 
proxy all files instead of using signed bucket urls
@mhuebert mhuebert marked this pull request as ready for review November 7, 2024 14:13
@mhuebert mhuebert merged commit 3904a21 into main Nov 7, 2024
@sritchie sritchie deleted the huebert/cache-worker branch November 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sritchie sritchie Awaiting requested review from sritchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhuebert