Add relations to HIRM in an order respecting their base_relations #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
emilyfertig
approved these changes
Sep 16, 2024
cxx/hirm.cc
Outdated
| if (std::holds_alternative<T_clean_relation>(relation)) { | ||
| this->add_relation(prng, name, relation); | ||
| HIRM::HIRM(const T_schema& _schema, std::mt19937* prng) { | ||
| printf("in hirm\n"); |
|
|
||
| if (!added_a_relation) { | ||
| printf("Detected loop in schema\n"); | ||
| std::exit(1); |
There was a problem hiding this comment.
We've used asserts everywhere else, let's stick with that.
There was a problem hiding this comment.
assert's are removed in optimized mode, so I've tried not to use them in places like this where continuing will lead to bad behavior (an infinite loop in this case). grep says that there are 19 such places in the codebase.
| } | ||
|
|
||
| if (!added_a_relation) { | ||
| printf("Detected loop in schema\n"); |
There was a problem hiding this comment.
I think it'd be helpful to print the relation name.
There was a problem hiding this comment.
This is outside of the loop over relations, so there is no single relation name to print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196