Put the panic handler behind a feature flag #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiwalun
requested changes
Feb 11, 2023
tgross35
force-pushed
the
feature-flag
branch
from
99956f5 to
65f84fe
Compare
tgross35
force-pushed
the
feature-flag
branch
from
65f84fe to
588c8ca
Compare
|
Whoops, sorry I missed that! I did the change, should be all set now |
Yatekii
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping with a panic handler was messing my docs with crates that had >1 binary. Not sure why that issue exists and it's not this crate's fault, but I figured putting the handler behind a feature flag isn't a bad idea just in case somebody wants something specific.
I don't currently have hardware to test this with, so please verify this works as intended if you are able to.